Conversation
dirtymew
suggested changes
Mar 28, 2025
dirtymew
left a comment
dirtymew
left a comment
There was a problem hiding this comment.
Привет Степан
хорошая работа - все верно реализовано
есть что улучшить см PR
| return err | ||
| } | ||
|
|
||
| rowsAffected, err := res.RowsAffected() |
There was a problem hiding this comment.
это ок - не ошибка
но нужно тогда main было поправить - иначе до конца не выполнится
| // проверьте, что значения всех полей в полученном объекте совпадают со значениями полей в переменной parcel | ||
| p, err := store.Get(id) | ||
| require.NoError(t, err) | ||
| require.Equal(t, id, p.Number) |
| // добавьте новую посылку в БД, убедитесь в отсутствии ошибки и наличии идентификатора | ||
| id, err := store.Add(parcel) | ||
| require.NoError(t, err) | ||
| require.True(t, id > 0) |
| for _, p := range storedParcels { | ||
| expected, ok := parcelMap[p.Number] | ||
| require.True(t, ok) | ||
| require.Equal(t, expected.Client, p.Client) |
|
|
||
| for _, p := range storedParcels { | ||
| expected, ok := parcelMap[p.Number] | ||
| require.True(t, ok) |
| // убедитесь, что значения полей полученных посылок заполнены верно | ||
| storedParcels, err := store.GetByClient(client) | ||
| require.NoError(t, err) | ||
| require.Equal(t, len(parcels), len(storedParcels)) |
| // получите добавленную посылку и убедитесь, что статус обновился | ||
| p, err := store.Get(id) | ||
| require.NoError(t, err) | ||
| require.Equal(t, ParcelStatusSent, p.Status) |
| // получите добавленную посылку и убедитесь, что адрес обновился | ||
| p, err := store.Get(id) | ||
| require.NoError(t, err) | ||
| require.Equal(t, newAddress, p.Address) |
| require.NoError(t, err) | ||
|
|
||
| _, err = store.Get(id) | ||
| require.ErrorIs(t, err, sql.ErrNoRows) |
There was a problem hiding this comment.
лучше так
require.Error
assert.ErrorIs
dirtymew
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.