Skip to content

Fix mixed row inference for PDOStatement::bindValue() + execute() #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaielab wants to merge 4 commits into
base: main
Choose a base branch
from
+69 −5
Open

Fix mixed row inference for PDOStatement::bindValue() + execute() #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bac4188
test: add regression case for PDOStatement::execute returning mixed rows
Apr 8, 2026
a7649f6
fix: preserve typed rows for PDO statements using bindValue() and exe…
Apr 8, 2026
43a371a
Replace instanceof ConstantStringType with getConstantStrings() API
Apr 13, 2026
dc55e81
Split ConstantIntegerType/ConstantStringType branches to satisfy Cons…
Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions src/Extensions/PdoStatementExecuteTypeSpecifyingExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
use PHPStan\Analyser\TypeSpecifierAwareExtension;
use PHPStan\Analyser\TypeSpecifierContext;
use PHPStan\Reflection\MethodReflection;
use PHPStan\Type\Constant\ConstantArrayType;
use PHPStan\Type\Constant\ConstantIntegerType;
use PHPStan\Type\MethodTypeSpecifyingExtension;
use PHPStan\Type\Type;
use staabm\PHPStanDba\PdoReflection\PdoStatementReflection;
Expand Down Expand Up @@ -62,9 +64,7 @@ private function inferStatementType(MethodReflection $methodReflection, MethodCa
{
$args = $methodCall->getArgs();

if (0 === \count($args)) {
return null;
}


$stmtReflection = new PdoStatementReflection();
$queryExpr = $stmtReflection->findPrepareQueryStringExpression($methodCall);
Expand All @@ -73,7 +73,32 @@ private function inferStatementType(MethodReflection $methodReflection, MethodCa
}

$queryReflection = new QueryReflection();
$parameterTypes = $queryReflection->resolveParameterTypes($args[0]->value, $scope);


if (0 === \count($args)) {
$parameterKeys = [];
$parameterValues = [];

foreach ($stmtReflection->findPrepareBindCalls($methodCall) as $bindCall) {
$bindArgs = $bindCall->getArgs();
if (\count($bindArgs) >= 2) {
$keyType = $scope->getType($bindArgs[0]->value);
$constantStrings = $keyType->getConstantStrings();
if ($keyType instanceof ConstantIntegerType) {
$parameterKeys[] = $keyType;
$parameterValues[] = $scope->getType($bindArgs[1]->value);
} elseif ([] !== $constantStrings) {
$parameterKeys[] = $constantStrings[0];
$parameterValues[] = $scope->getType($bindArgs[1]->value);
}
}
}

$parameterTypes = new ConstantArrayType($parameterKeys, $parameterValues);
} else {
$parameterTypes = $queryReflection->resolveParameterTypes($args[0]->value, $scope);
}

$queryStrings = $queryReflection->resolvePreparedQueryStrings($queryExpr, $parameterTypes, $scope);

$reflectionFetchType = QueryReflection::getRuntimeConfiguration()->getDefaultFetchMode();
Expand Down
41 changes: 40 additions & 1 deletion tests/default/data/pdo-stmt-execute.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ class Foo
{
public function execute(PDO $pdo)
{

$stmt = $pdo->prepare('SELECT email, adaid FROM ada WHERE adaid = :adaid');
$stmt->execute([':adaid' => 1]);
foreach ($stmt as $row) {
Expand All @@ -33,11 +34,12 @@ public function execute(PDO $pdo)
assertType('array{email: string, 0: string, adaid: int<-32768, 32767>, 1: int<-32768, 32767>}', $row);
}

$stmt = $pdo->prepare('SELECT email, adaid FROM ada WHERE adaid = ? and email = ?');
$stmt = $pdo->prepare('SELECT email, adaid FROM ada WHERE adaid = ? and email = ? ');
$stmt->execute([1, 'email@example.org']);
foreach ($stmt as $row) {
assertType('array{email: string, 0: string, adaid: int<-32768, 32767>, 1: int<-32768, 32767>}', $row);
}

}

public function executeWithBindCalls(PDO $pdo)
Expand All @@ -48,6 +50,43 @@ public function executeWithBindCalls(PDO $pdo)
$stmt->bindParam(':test1', $test);
$stmt->bindValue(':test2', 1001);
$stmt->execute();

$stmt = $pdo->prepare('SELECT email, adaid FROM ada WHERE adaid = :adaid');
$stmt->bindValue(':adaid', 1);
$stmt->execute();
foreach ($stmt as $row) {
assertType('array{email: string, 0: string, adaid: int<-32768, 32767>, 1: int<-32768, 32767>}', $row);
}

$stmt = $pdo->prepare('SELECT email, adaid FROM ada WHERE adaid = :adaid');
$stmt->bindValue('adaid', 1);
$stmt->execute(); // prefixed ":" is optional
foreach ($stmt as $row) {
assertType('array{email: string, 0: string, adaid: int<-32768, 32767>, 1: int<-32768, 32767>}', $row);
}

$stmt = $pdo->prepare('SELECT email, adaid FROM ada WHERE email = :email');
$stmt->bindValue(':email', 'email@example.org');
$stmt->execute();
foreach ($stmt as $row) {
assertType('array{email: string, 0: string, adaid: int<-32768, 32767>, 1: int<-32768, 32767>}', $row);
}

$stmt = $pdo->prepare('SELECT email, adaid FROM ada WHERE adaid = ?');
$stmt->bindValue(1, 1);
$stmt->execute();
foreach ($stmt as $row) {
assertType('array{email: string, 0: string, adaid: int<-32768, 32767>, 1: int<-32768, 32767>}', $row);
}

$stmt = $pdo->prepare('SELECT email, adaid FROM ada WHERE adaid = ? and email = ? ');
$stmt->bindValue(1, 1);
$stmt->bindValue(2, 'email@example.org');
$stmt->execute();
foreach ($stmt as $row) {
assertType('array{email: string, 0: string, adaid: int<-32768, 32767>, 1: int<-32768, 32767>}', $row);
}

}

public function errors(PDO $pdo)
Expand Down
Loading