fix: support PDOStatement subclasses in PdoStatementExecuteMethodRule#773
Open
vaielab wants to merge 2 commits intostaabm:mainfrom
Open
fix: support PDOStatement subclasses in PdoStatementExecuteMethodRule#773vaielab wants to merge 2 commits intostaabm:mainfrom
vaielab wants to merge 2 commits intostaabm:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, me again! Here is another problem I found while using your extension. Hope this helps.
Problem
PdoStatementExecuteMethodRulewas skipping analysis whenexecute()is called on a subclass ofPDOStatementthat overrides the method. This is because the rule checked whetherexecute()was declared inPDOStatement:When a subclass overrides execute(), the declaring class is the subclass and not PDOStatement, so the rule bailed out early, silently missing placeholder errors.
Fix
Replace the declaring-class check with a type check on the call's receiver:
This correctly handles PDOStatement itself and any subclass, regardless ofwhether execute() is inherited or overridden.
Tests