Move -Werror to pyproject.toml #841
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #841 +/- ##
==========================================
+ Coverage 93.43% 95.06% +1.63%
==========================================
Files 13 15 +2
Lines 990 1217 +227
==========================================
+ Hits 925 1157 +232
+ Misses 65 60 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ing handling across all test runs. Removes redundant decorators.
nlebovits
force-pushed
the
lebovits/837-add-werror-to-pyproject
branch
from
c498bd4 to
19ccb0c
Compare
jsignell
reviewed
Oct 21, 2025
| ./scripts/lint | ||
| ./scripts/format | ||
| # Test suite with coverage enabled | ||
| pytest -Werror --cov pystac_client --cov-report term-missing |
There was a problem hiding this comment.
You shouldn't need to put it here. It should be coming from the pyproject.toml anyways.
There was a problem hiding this comment.
Thanks for the review! Just to clarify--is my change wrong? I moved the -Werror flag from scripts/test to pyproject.toml, which I thought was the intended update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
-Werrorto pyproject.toml #837Description:
Moves -Werror from scripts/test to pyproject.toml for consistent warning handling across all test runs. Removes redundant decorators.
PR Checklist: