-
-
Notifications
You must be signed in to change notification settings - Fork 142
patch DOM insertBefore and removeChild, workaround for DOM translators #2937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
huumn
merged 4 commits into
stackernews:master
from
Soxasora:fix/react-dom-translations
Apr 27, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /* global Node */ | ||
|
|
||
| let translateActive = false | ||
|
|
||
| function detectDOMTranslate () { | ||
| const html = document.documentElement | ||
| if (!html) return false | ||
|
|
||
| // classes used by DOM translators | ||
| if (html.classList.contains('translated-ltr')) return true | ||
| if (html.classList.contains('translated-rtl')) return true | ||
| if (html.classList.contains('translated')) return true | ||
|
|
||
| return false | ||
| } | ||
|
|
||
| /** | ||
| * workaround for DOM translators, facebook/react#11538 | ||
| * browser translation engines wrap text nodes in <font> tags, | ||
| * which desyncs React's reconciler from the real DOM and throws | ||
| * `NotFoundError` on `removeChild` and `insertBefore` | ||
| * | ||
| * We only suppress these errors while a DOM translator is active | ||
| */ | ||
| export function patchDOMTranslations () { | ||
| if (typeof Node === 'undefined' || typeof window === 'undefined') return | ||
| if (Node.prototype.__patchedDOMTranslations) return | ||
|
|
||
| Node.prototype.__patchedDOMTranslations = true | ||
|
|
||
| const originalRemoveChild = Node.prototype.removeChild | ||
| const originalInsertBefore = Node.prototype.insertBefore | ||
|
|
||
| Node.prototype.removeChild = function (child) { | ||
| if (child && child.parentNode !== this) { | ||
| if (translateActive) { | ||
| return child | ||
| } | ||
| } | ||
| return originalRemoveChild.call(this, child) | ||
| } | ||
|
|
||
| Node.prototype.insertBefore = function (newNode, referenceNode) { | ||
| if (referenceNode && referenceNode.parentNode !== this) { | ||
| if (translateActive) { | ||
| // append so the node still ends up under the expected parent, React will correct on the next render | ||
| return this.appendChild(newNode) | ||
| } | ||
| } | ||
| return originalInsertBefore.call(this, newNode, referenceNode) | ||
| } | ||
|
Comment on lines
+43
to
+51
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could technically fallback to
cursor[bot] marked this conversation as resolved.
|
||
|
|
||
| const update = () => { translateActive = detectDOMTranslate() } | ||
| update() | ||
|
|
||
| const observer = new window.MutationObserver(update) | ||
| observer.observe(document.documentElement, { | ||
| attributes: true, | ||
| attributeFilter: ['class', 'lang'] | ||
| }) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*only Chromium-based DOM translations, needs to be tested on Safari and Firefox.