-
Notifications
You must be signed in to change notification settings - Fork 38
feat(ske): add datasource to query provider options #1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(ske): add datasource to query provider options #1047
Conversation
2b4b6de to
f5062fe
Compare
|
Even if the API does not allow for filtering at the moment, we should still support filtering in the terraform go code. |
f5062fe to
186901b
Compare
|
Closes #953 |
f0516e4 to
1082886
Compare
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
1082886 to
9315710
Compare
| ## Example Usage | ||
|
|
||
| ```terraform | ||
| data "stackit_ske_provider_options" "default" {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list provider options endpoint returns a lot of different information.
I wouldn't combine all of this into a single datasource, instead I would create multiple datasources here. (IMO there should be also multiple endpoints for listing k8s versions, listing machine types, ... but that's another discussion.)
So I would suggest
- datasource
stackit_ske_kubernetes_versions - datasource
stackit_ske_machine_types - datasource
stackit_ske_volume_types - ...
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
31e0a82 to
3b48368
Compare
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
3b48368 to
8c9e943
Compare
|
I've just implemented your suggestion. While some work remains, could you please verify if this approach is heading in the right direction? I've split the functionality into 5 different data sources:
Will also get the versionState flag once it is merged into the go-sdk: I haven't yet identified a customer use case for the |
Description
This PR adds the ske options API as datasource to query kubernetes and machine versions. Currently the API does not support any filtering option, but this can be done in the meanwhile using terraform locals. Example code is in the generated docs.
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)