chore(iaas): fix acc tests #1059
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
marceljk
reviewed
Nov 17, 2025
Comment on lines
-3632
to
+3635
| resource.TestCheckResourceAttrPair( | ||
| "stackit_public_ip.public_ip_simple", "network_interface_id", | ||
| "stackit_network_interface.network_interface_simple", "network_interface_id", | ||
| ), | ||
| // The network gets re-created, which triggers a re-create of the 'network_interface_simple' NIC, which leads the 'stackit_public_ip_associate' resource to update the | ||
| // networkInterfaceId of the public IP. All that without the public ip resource noticing. So the public ip resource will still hold the networkInterfaceId of the old NIC. | ||
| // So we can only check that *some* network interface ID is set here, but can't compare it with the networkInterfaceId of the NIC resource (old vs. new NIC id) | ||
| resource.TestCheckResourceAttrSet("stackit_public_ip.public_ip_simple", "network_interface_id"), |
Contributor
There was a problem hiding this comment.
No blame on you, this test case was the last time changed by me, so probably I mixed up something.
I think we should adjust the tests, to prevent the recreation of the network interfaces. Actually not to prevent the error you commented, but to test the intended case here is. This would be in my opinion, to check if the Update function of network interface works as expected.
With the current test cases, the update function isn't covered in the tests
marceljk
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)