Skip to content

Conversation

@rubenhoenle
Copy link
Member

@rubenhoenle rubenhoenle commented Nov 17, 2025

Description

relates to STACKITTPR-416

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle requested a review from a team as a code owner November 17, 2025 11:37
@rubenhoenle rubenhoenle self-assigned this Nov 17, 2025
@rubenhoenle rubenhoenle force-pushed the feat/STACKITTPR-416-kms-onboarding-wrappingkey branch from fe9c8a7 to 542e8fe Compare November 17, 2025 11:44
@rubenhoenle rubenhoenle force-pushed the feat/STACKITTPR-416-kms-onboarding-wrappingkey branch from 542e8fe to 89c440b Compare November 17, 2025 13:44
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit 1.85% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/wrapping-key 15.14% (+15.14%) 🎉

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/wrapping-key/datasource.go 0.00% (ø) 38 (+38) 0 38 (+38)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/wrapping-key/resource.go 19.05% (+19.05%) 147 (+147) 28 (+28) 119 (+119) 🎉
github.com/stackitcloud/terraform-provider-stackit/stackit/provider.go 1.85% (ø) 108 2 106

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/kms_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/wrapping-key/resource_test.go

@rubenhoenle rubenhoenle merged commit 7709986 into main Nov 18, 2025
5 checks passed
@rubenhoenle rubenhoenle deleted the feat/STACKITTPR-416-kms-onboarding-wrappingkey branch November 18, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants