Skip to content

Conversation

Fyusel
Copy link
Contributor

@Fyusel Fyusel commented Aug 22, 2025

Description

fixes #930

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel Fyusel requested a review from a team as a code owner August 22, 2025 07:05
@Fyusel Fyusel force-pushed the fix/observability-plans-bug branch from 852ff89 to 9909e1a Compare August 22, 2025 07:08
@rubenhoenle
Copy link
Member

rubenhoenle commented Aug 26, 2025

  • As discussed in our meeting, please make it clear in the docs that the some configuration options only get applied for the correct plan.

@Fyusel Fyusel force-pushed the fix/observability-plans-bug branch from 9909e1a to cf49532 Compare August 26, 2025 14:42
Copy link

github-actions bot commented Sep 3, 2025

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Sep 3, 2025
@github-actions github-actions bot removed the Stale PR is marked as stale due to inactivity. label Sep 4, 2025
@Fyusel Fyusel force-pushed the fix/observability-plans-bug branch 5 times, most recently from d2ba60b to cdb6693 Compare September 8, 2025 09:35
marceljk
marceljk previously approved these changes Sep 8, 2025
…s or store metrics.

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@Fyusel Fyusel enabled auto-merge (squash) September 9, 2025 07:54
Copy link

github-actions bot commented Sep 9, 2025

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance 38.08% (-0.52%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/datasource.go 0.00% (ø) 78 (+6) 0 78 (+6)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/resource.go 41.71% (-0.31%) 820 (+6) 342 478 (+6) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@Fyusel Fyusel merged commit 8f8124e into main Sep 9, 2025
5 checks passed
@Fyusel Fyusel deleted the fix/observability-plans-bug branch September 9, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using stackit_observability_instance as metrics endpoint
3 participants