Use status files to retrieve PID

[dmjb]

This follows on from the previous PRs which migrated PIDs from the PID files to status files.

[codecov]

Codecov Report

❌ Patch coverage is 30.39216% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.36%. Comparing base (70fc85c) to head (0715fb7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/workloads/manager.go	16.21%	27 Missing and 4 partials ⚠️
pkg/workloads/statuses/file_status.go	48.07%	24 Missing and 3 partials ⚠️
...kg/workloads/statuses/mocks/mock_status_manager.go	0.00%	9 Missing ⚠️
pkg/workloads/statuses/status.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1805      +/-   ##
==========================================
- Coverage   47.37%   47.36%   -0.01%     
==========================================
  Files         233      232       -1     
  Lines       28649    28644       -5     
==========================================
- Hits        13572    13568       -4     
+ Misses      14062    14059       -3     
- Partials     1015     1017       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coveralls]

coverage: 43.601% (+0.05%) from 43.554%
when pulling 64b9442 on use-status-file-for-pids
into d15faf0 on main.

[eleftherias]

question: It looks like the status for remote workloads is still reading from the PID file instead of the status file, is that intentional?

toolhive/pkg/workloads/manager.go

Lines 870 to 889 in ffdb3ff

	func (d *defaultManager) getRemoteWorkloadState(ctx context.Context, name, baseName string) *workloadState {
	workloadSt := &workloadState{
	BaseName: baseName,
	}
	// Check the workload status
	workload, err := d.statuses.GetWorkload(ctx, name)
	if err != nil {
	// If we can't get the status, assume it's not running
	logger.Debugf("Failed to get status for remote workload %s: %v", name, err)
	workloadSt.Running = false
	} else {
	workloadSt.Running = workload.Status == rt.WorkloadStatusRunning
	}
	// Check if the detached process is actually running
	workloadSt.ProxyRunning = proxy.IsRunning(baseName)
	return workloadSt
	}

toolhive/pkg/transport/proxy/manager.go

Lines 41 to 65 in ffdb3ff

	func IsRunning(containerBaseName string) bool {
	logger.Debugf("Checking if proxy process is running for container %s", containerBaseName)
	if containerBaseName == "" {
	logger.Warnf("Warning: Could not find base container name in labels")
	return false
	}
	// Try to read the PID file
	logger.Debugf("Reading PID file for container %s", containerBaseName)
	pid, err := process.ReadPIDFile(containerBaseName)
	if err != nil {
	logger.Debugf("No PID file found for container %s", containerBaseName)
	return false
	}
	// Check if the process exists and is running
	logger.Debugf("Checking if process with PID %d is running", pid)
	isRunning, err := process.FindProcess(pid)
	if err != nil {
	logger.Warnf("Warning: Error checking process: %v", err)
	return false
	}
	return isRunning
	}