-
Notifications
You must be signed in to change notification settings - Fork 115
Add file-based registry provider to thv-registry-api #1909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1909 +/- ##
==========================================
+ Coverage 46.90% 47.06% +0.15%
==========================================
Files 220 223 +3
Lines 27319 27522 +203
==========================================
+ Hits 12814 12953 +139
- Misses 13530 13584 +54
- Partials 975 985 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm apart from a minor comment
Extends the registry API server to support reading registry data from local files in addition to Kubernetes ConfigMaps. This enables deployment scenarios where ConfigMaps are mounted as volumes rather than accessed via the Kubernetes API. The server now accepts either: - `--configmap` flag: Reads from Kubernetes ConfigMap via API - `--file` flag: Reads from mounted file (for volume-mounted ConfigMaps)
4823ae4
to
5968bd8
Compare
there was one lint issue, the tests failed only because coveralls timed out |
Extends the registry API server to support reading registry data from local files in addition to Kubernetes ConfigMaps. This enables deployment scenarios where ConfigMaps are mounted as volumes rather than accessed via the Kubernetes API.
The server now accepts either:
--configmap
flag: Reads from Kubernetes ConfigMap via API--file
flag: Reads from mounted file (for volume-mounted ConfigMaps)