Skip to content

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 16, 2025

Extends the registry API server to support reading registry data from local files in addition to Kubernetes ConfigMaps. This enables deployment scenarios where ConfigMaps are mounted as volumes rather than accessed via the Kubernetes API.

The server now accepts either:

  • --configmap flag: Reads from Kubernetes ConfigMap via API
  • --file flag: Reads from mounted file (for volume-mounted ConfigMaps)

Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 45.71429% with 114 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.06%. Comparing base (24a2f37) to head (4a58efa).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
cmd/thv-registry-api/app/serve.go 0.00% 72 Missing ⚠️
...-registry-api/internal/service/provider_factory.go 77.50% 12 Missing and 6 partials ⚠️
...pi/internal/service/mocks/mock_provider_factory.go 0.00% 15 Missing ⚠️
...gistry-api/internal/service/mocks/mock_provider.go 0.00% 8 Missing ⚠️
...thv-registry-api/internal/service/file_provider.go 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1909      +/-   ##
==========================================
+ Coverage   46.90%   47.06%   +0.15%     
==========================================
  Files         220      223       +3     
  Lines       27319    27522     +203     
==========================================
+ Hits        12814    12953     +139     
- Misses      13530    13584      +54     
- Partials      975      985      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Collaborator

coveralls commented Sep 16, 2025

Coverage Status

coverage: 44.419% (+0.2%) from 44.242%
when pulling 4a58efa on thv-registry-api-file
into 24a2f37 on main.

Copy link
Collaborator

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm apart from a minor comment

yrobla
yrobla previously approved these changes Sep 17, 2025
Extends the registry API server to support reading registry data from
local files in addition to Kubernetes ConfigMaps. This enables
deployment scenarios where ConfigMaps are mounted as volumes rather
than accessed via the Kubernetes API.

The server now accepts either:
- `--configmap` flag: Reads from Kubernetes ConfigMap via API
- `--file` flag: Reads from mounted file (for volume-mounted ConfigMaps)
@jhrozek
Copy link
Contributor Author

jhrozek commented Sep 17, 2025

there was one lint issue, the tests failed only because coveralls timed out

@jhrozek jhrozek merged commit b92b9e7 into main Sep 18, 2025
30 of 31 checks passed
@jhrozek jhrozek deleted the thv-registry-api-file branch September 18, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants