-
Notifications
You must be signed in to change notification settings - Fork 115
Git Source Handler for MCPRegistry #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes unknown |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
+ Coverage 47.11% 47.38% +0.26%
==========================================
Files 231 233 +2
Lines 28378 28649 +271
==========================================
+ Hits 13369 13574 +205
- Misses 14011 14061 +50
- Partials 998 1014 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces Git repository support for MCPRegistry sources, allowing registry data to be fetched directly from Git repositories instead of just ConfigMaps. This expands the flexibility of the registry system by enabling declarative management of MCP server registries through Git.
Key changes:
- Added Git source handler with support for branch, tag, and commit-based checkouts
- Implemented comprehensive Git client using go-git library
- Extended MCPRegistry CRD with Git source configuration
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
go.mod | Adds go-git dependency and related Git operation libraries |
cmd/thv-operator/api/v1alpha1/mcpregistry_types.go | Extends MCPRegistry CRD with GitSource type and validation |
cmd/thv-operator/pkg/sources/git.go | Implements Git source handler for fetching registry data from repositories |
cmd/thv-operator/pkg/git/client.go | Core Git client implementation with clone, checkout, and file operations |
deploy/charts/operator-crds/templates/toolhive.stacklok.dev_mcpregistries.yaml | Updates CRD schema to include Git source configuration |
examples/operator/mcp-registries/*.yaml | Provides example configurations for Git-based registry sources |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, some questions about performance, most can be deferred but should be at least tracked.
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
71d0d6c
to
5491060
Compare
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
…mance. - Add logging for clone duration and repository metrics Signed-off-by: Daniele Martinoli dmartino@redhat.com Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Looks good once we fix the lint issues! |
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Fixes: #1924