Merged
Conversation
5300432 to
60c4239
Compare
60c4239 to
d9ddff7
Compare
6 tasks
remove command which installs sqlite 3.23, when previous step creates "test" env w/ sqlite 3.45,
This reverts commit c88a306.
e8242b2 to
be74c4e
Compare
Collaborator
Author
|
@gadomski -- do you have the keys to drop py3.8 from the required python-matrix here? |
Contributor
Done, added 3.12 and 3.13 🙇🏼 |
gadomski
approved these changes
May 12, 2025
Contributor
gadomski
left a comment
There was a problem hiding this comment.
moves mypy to a local pre-commit hook, as stubs were not being well handled by the repo-based hook
Thanks for this ... one of the big reasons I'm moving away from pre-commit personally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
PR checklist:
scripts/format).scripts/lint).scripts/test).