Skip to content

Support 1c and 1d#62

Merged
ircwaves merged 15 commits intostactools-packages:mainfrom
ircwaves:support-1c-and-1d
May 12, 2025
Merged

Support 1c and 1d#62
ircwaves merged 15 commits intostactools-packages:mainfrom
ircwaves:support-1c-and-1d

Conversation

@ircwaves
Copy link
Collaborator

@ircwaves ircwaves commented Mar 10, 2025

Description:

  • add support for S1C and S1D
  • moves mypy to a local pre-commit hook, as stubs were not being well handled by the repo-based hook

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Examples have been updated to reflect changes, if applicable
  • Changes are added to the CHANGELOG.

@ircwaves ircwaves force-pushed the support-1c-and-1d branch 2 times, most recently from 5300432 to 60c4239 Compare March 10, 2025 20:44
@ircwaves ircwaves force-pushed the support-1c-and-1d branch from e8242b2 to be74c4e Compare May 12, 2025 20:36
@ircwaves
Copy link
Collaborator Author

@gadomski -- do you have the keys to drop py3.8 from the required python-matrix here?

@ircwaves ircwaves requested a review from gadomski May 12, 2025 20:57
@gadomski
Copy link
Contributor

do you have the keys to drop py3.8 from the required python-matrix here?

Done, added 3.12 and 3.13 🙇🏼

Copy link
Contributor

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moves mypy to a local pre-commit hook, as stubs were not being well handled by the repo-based hook

Thanks for this ... one of the big reasons I'm moving away from pre-commit personally.

@ircwaves ircwaves merged commit e18681b into stactools-packages:main May 12, 2025
6 checks passed
@ircwaves ircwaves mentioned this pull request May 13, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants