fix: chart symbol mapping #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
petar-omni
force-pushed
the
fix/chart-symbol-mapping
branch
from
03c3454 to
55f5736
Compare
There was a problem hiding this comment.
Pull request overview
Fixes ENG-1176 by improving TradingView chart symbol resolution so the chart uses the correct provider + symbol pair instead of a hardcoded fallback.
Changes:
- Refactors the Position Details chart into a new
Overview/Chartmodule that resolvesproviderId:symbolvia a generated mapping. - Adds
tradingview-symbols.json+ a generator script to produce/refresh the mapping. - Centralizes and preloads the TradingView widget script URL to reduce load latency.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/constants.ts | Introduces a shared TradingView widget script URL constant. |
| src/app.tsx | Preloads the TradingView script at app start. |
| src/components/modules/PositionDetails/Overview/index.tsx | Switches to the new named Chart export/module. |
| src/components/modules/PositionDetails/Overview/chart.tsx | Removes the old chart implementation. |
| src/components/modules/PositionDetails/Overview/Chart/state.ts | Adds symbol mapping atom + chart interval constants. |
| src/components/modules/PositionDetails/Overview/Chart/index.tsx | New chart implementation that embeds TradingView using provider/symbol mapping and updates interval via postMessage. |
| src/assets/tradingview-symbols.json | Adds the provider/symbol mapping dataset used by the chart. |
| scripts/generate-tradingview-symbols.ts | Adds a script to generate/update the mapping JSON from Perps + TradingView search. |
| src/components/molecules/token-balances-select.tsx | Removes unnecessary useCallback usage. |
| src/components/molecules/provider-select.tsx | Removes unnecessary useCallback usage. |
| package.json | Adds a generate-tradingview-symbols script entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+134
to
+137
| iframeRef.current.contentWindow.postMessage( | ||
| { name: "set-interval", data: { interval: newInterval } }, | ||
| "*", | ||
| ); |
There was a problem hiding this comment.
postMessage is sent with targetOrigin "*". Since the message is intended only for the TradingView iframe, it would be safer to restrict targetOrigin to the iframe's actual origin (e.g. derive it from iframeRef.current.src) to avoid sending messages if the iframe navigates to a different origin.
Philippoes
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ENG-1176