Skip to content

Conversation

@jdomingos
Copy link
Contributor

Added

This pull request introduces Sui blockchain support to the @stakekit/signers package, enabling Sui wallet derivation and transaction signing. It also updates several dependencies and improves derivation path management for multiple wallets.

Sui blockchain integration:

  • Added new src/sui.ts module implementing SuiSigner and SuiKeypairSigner for Sui key derivation and transaction signing.
  • Integrated Sui wallet support into get-signing-wallet.ts, including a new getter and wiring for the Sui network. [1] [2] [3]

Derivation path enhancements:

  • Added Sui derivation path logic (suiPath) and included Sui in WalletDomain, steakwalletDerivationPaths, and phantomDerivationPaths to support Sui in various wallet types. Updated walletDerivationPaths to use the new structure. [1] [2] [3] [4]

Dependency and configuration updates:

  • Added @mysten/sui and @types/bech32 as dependencies, updated @stakekit/common, and bumped TypeScript and Node.js type definitions. Set "type": "commonjs" in package.json. [1] [2] [3] [4]

Other improvements:

  • Fixed a type assertion for provider in NonceManager to ensure correct typing.

These changes collectively enable Sui blockchain support, improve wallet compatibility, and keep dependencies up to date.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces Sui blockchain support to the @stakekit/signers package, enabling wallet derivation and transaction signing for the Sui network. It also updates dependencies and refines wallet derivation path management.

Key changes:

  • Implements Sui signer functionality with Ed25519 keypair support
  • Integrates Sui into the wallet derivation path system across multiple wallet types
  • Updates package dependencies including TypeScript, Node types, and the addition of @mysten/sui

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/sui.ts New module implementing Sui signer classes and wallet getter function
src/get-signing-wallet.ts Adds Sui signing wallet function and registers it in the network getters map
src/ethereum/nonce-manager.ts Adds type assertion for provider field to satisfy type requirements
src/constants.ts Adds Sui derivation paths and integrates Sui support into wallet configurations
package.json Bumps version to 0.1.0, adds Sui dependency, and updates TypeScript and other dependencies
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

package.json Outdated
"@solana/web3.js": "1.52.0",
"@stakekit/common": "^0.0.56",
"@stakekit/common": "^0.0.58",
"@stakekit/signers": "link:",
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency '@stakekit/signers' appears to be a self-reference with 'link:' protocol. This is likely a development artifact and should be removed before publishing, as packages should not depend on themselves.

Suggested change
"@stakekit/signers": "link:",

Copilot uses AI. Check for mistakes.
@Philippoes Philippoes merged commit e645d49 into main Oct 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants