Add osToken redeem multiplier #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds an os_token_redeem_multiplier field to the ProtocolConfig dataclass to adjust redemption assets for potential osToken rate increases, defaulting to 1.0023 (~0.23% adjustment based on historical APR).
Changes:
- Added
os_token_redeem_multiplieras aDecimalfield toProtocolConfig - Updated configuration builder to load the multiplier with a default value
- Refactored test factories to use
Web3.to_hex()for generating hex strings and addedHexStrtype hints
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sw_utils/typings.py | Added os_token_redeem_multiplier field with Decimal type to ProtocolConfig |
| sw_utils/protocol_config.py | Implemented loading logic for the new multiplier field with default value of 1.0023 |
| sw_utils/tests/factories.py | Updated test factory to include the multiplier and refactored hex string generation methods |
| pyproject.toml | Bumped version from v0.12.2 to v0.12.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cyc60
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.