Add redemption assets to validators checker #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for redemption assets in the validators checker by introducing a new parameter to the getExitQueueMissingAssets function. The redemption assets are now included in the calculation of missing assets needed to cover exit queue tickets.
Key Changes
- Added
redemptionAssetsparameter togetExitQueueMissingAssetsfunction signature in the interface and implementation - Updated the missing assets calculation to initialize with redemption assets before adding legacy and queued share requirements
- Updated all test cases to pass the new redemption assets parameter (set to 0 in all tests)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| contracts/interfaces/IValidatorsChecker.sol | Added redemptionAssets parameter to the getExitQueueMissingAssets function interface |
| contracts/validators/ValidatorsChecker.sol | Implemented redemption assets support in missing assets calculation and refactored control flow |
| test/EthValidatorsChecker.t.sol | Updated all test calls to include the new redemption assets parameter (set to 0) |
| test/gnosis/GnoValidatorsChecker.t.sol | Updated all test calls to include the new redemption assets parameter (set to 0) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Forge code coverage:
|
tsudmi
force-pushed
the
implement-redemptions
branch
from
66e6f8a to
92eb8c8
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 37 out of 37 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 132 out of 132 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 132 out of 132 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 148 out of 148 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 147 out of 147 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.