Fix code review issues for redemptions #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request addresses code review feedback for the redemptions feature by reorganizing import statements to follow a consistent ordering pattern and correcting event emissions in factory contracts.
Changes:
- Reorganized import statements across multiple files to place external library imports before internal imports
- Updated event emissions in factory contracts to include the caller address parameter
- Relocated function definitions within library files for better organization
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| script/UpgradeGnoNetwork.s.sol | Moved console import to follow standard import ordering |
| script/UpgradeEthNetwork.s.sol | Moved console import to follow standard import ordering |
| script/Network.sol | Reorganized imports to place external libraries before internal imports |
| contracts/vaults/gnosis/GnoPrivMetaVault.sol | Moved Initializable import to precede internal imports |
| contracts/vaults/gnosis/GnoPrivErc20Vault.sol | Fixed comment referencing wrong contract name (EthPrivMetaVault → GnoPrivErc20Vault) |
| contracts/vaults/gnosis/GnoMetaVaultFactory.sol | Added caller parameter to MetaVaultCreated event emission |
| contracts/vaults/gnosis/GnoMetaVault.sol | Reorganized imports with external libraries first |
| contracts/vaults/ethereum/EthPrivMetaVault.sol | Moved external library imports before internal imports |
| contracts/vaults/ethereum/EthMetaVaultFactory.sol | Added caller parameter to MetaVaultCreated event emission |
| contracts/vaults/ethereum/EthMetaVault.sol | Reorganized imports with external libraries first |
| contracts/tokens/OsTokenRedeemer.sol | Reorganized imports following standard ordering |
| contracts/tokens/GnoOsTokenRedeemer.sol | Moved external library imports before internal imports |
| contracts/tokens/EthOsTokenRedeemer.sol | Moved external library imports before internal imports |
| contracts/libraries/SubVaultUtils.sol | Relocated calculateSubVaultsRedemptions and _isSubVaultCollateralized functions |
| contracts/interfaces/IGnoMetaVaultFactory.sol | Updated event signature to include caller parameter |
| contracts/interfaces/IEthMetaVaultFactory.sol | Updated event signature to include caller parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Forge code coverage:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.