Update web3py #109
Merged
Update web3py #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase to use a newer version of web3py, requiring API changes and adding proper client cleanup. The sw-utils dependency is rolled back to v0.10.6 to maintain compatibility.
- Updated web3py API calls to use snake_case method names instead of camelCase
- Added proper resource cleanup with client disconnection in finally blocks
- Refactored main keeper loop to ensure clients are closed on shutdown
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.py | Refactored keeper startup to wrap the main loop in try-finally block ensuring client cleanup |
| src/common/startup_check.py | Added finally blocks to disconnect consensus and execution clients after startup checks |
| src/common/contracts.py | Updated web3py method calls from camelCase to snake_case (encode_abi, from_block, to_block) |
| src/common/clients.py | Updated middleware construction to use SignAndSendRawMiddlewareBuilder and added close_clients function |
| pyproject.toml | Rolled back sw-utils version from v0.11.0 to v0.10.6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
evgeny-stakewise
approved these changes
Dec 10, 2025
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.