-
Notifications
You must be signed in to change notification settings - Fork 6
Sub vaults #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sub vaults #339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces functionality to retrieve and manage sub-vaults within a meta vault structure, allowing users to query information about vaults that are allocated within a parent meta vault.
Changes:
- Added
getSubVaultsmethod to retrieve sub-vault information including APY, assets, and exit queue data - Extended the allocator GraphQL query to include APY field
- Added
isStateUpdateRequiredfunction to the DefaultVaultAbi contract
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/vault/requests/index.ts | Exports the new getSubVaults function and its input type |
| src/services/vault/requests/getSubVaults/index.ts | Implements the main logic for fetching and aggregating sub-vault data |
| src/services/vault/requests/getSubVaults/getSubVaults.md | Provides API documentation for the getSubVaults method |
| src/services/vault/index.ts | Adds the public getSubVaults method to the Vault service class |
| src/graphql/subgraph/vault/subVaultsQuery.graphql | Defines the GraphQL query for fetching sub-vaults |
| src/graphql/subgraph/vault/index.ts | Exports the SubVaults query types and fetch function |
| src/graphql/subgraph/allocator/allocatorsQuery.graphql | Adds apy field to the allocators query |
| src/contracts/vault/abis/DefaultVaultAbi.json | Adds isStateUpdateRequired function to the vault ABI |
| changelog/next-release.md | Documents the addition of the getSubVaults method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| ] | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove empty lines?
No description provided.