Refactored the code and improved the output format#5
Open
bradenbest wants to merge 1 commit intostandupmaths:mainfrom
Open
Refactored the code and improved the output format#5bradenbest wants to merge 1 commit intostandupmaths:mainfrom
bradenbest wants to merge 1 commit intostandupmaths:mainfrom
Conversation
chiefly, I removed a lot of duplicate code and improved the output format to print out a table (here's a [screenshot](https://imgur.com/DT4enHV)), which allowed for much more compact and easy-to-scan output. This was only done for the data printouts, so the "personality" is preserved. The refactored code is heavily stateful, like the original. The state is now encapsulated within a class, which while not ideal is better than having it scattered throughout the function, and several inefficient constructs (like that "yes" variable) have been simplified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chiefly, I removed a lot of duplicate code and improved the output format to print out a table (screenshot below), which allowed for much more compact and easy-to-scan output. This was only done for the data printouts, so the "personality" is preserved.
The refactored code is heavily stateful, like the original. The state is now encapsulated within a class, which while not ideal is easier to comprehend than having it scattered throughout the function, and several inefficient constructs (like that "yes" variable) have been simplified. The code is easier to understand, and that's what matters.
Cheers,
-Braden