Tried to compile your code using cython, didn't really work #5
Closed
JMennenga wants to merge 3 commits intostandupmaths:mainfrom
JMennenga:main
Closed
Tried to compile your code using cython, didn't really work #5JMennenga wants to merge 3 commits intostandupmaths:mainfrom JMennenga:main
JMennenga wants to merge 3 commits intostandupmaths:mainfrom
JMennenga:main
Conversation
|
#7 adds type annotations where type inference doesn't work! Are type annotations needed everywhere? |
|
Did you try PyPy? Extrapolated, pypy3 will take about 40 minutes on WSL2 on NTFS. And my results for python3 on WSL2 on NTFS: About 17 hours to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Matt,
I tried to compile your code using cython, it barely improved the speed.
If you want to try it you can do it using the command
python setup.py build_ext --inplace
followed by
python fiveletterwords.py
I also sped up the file loading, by using a ramdisk, that worked well.
If you didn't already know cython, it's really handy to speed up python code by compilng it to an optimized executable via C.
It needs typeannotations to really perform its magic, but when I tried to use pyannotate on your code it didn't find any types, so it couldn't do its thing. Someone with more patience could manually do the type annotations and try compiling again.
Well, it was worth a try.
Have a good day
Jannes