Open
Conversation
Contributor
|
This seems to be the best simulator so far 👍 |
Merged
Member
|
Hi @DutChen18, thanks for opening this PR! Matt asked me to help with maintaining this repository, and I think having a simulator available would be nice. I love some of the others which all look really polished - but this one stood out for its simplicity. A few thoughts:
Would you be willing to make a few changes based on those? Alternatively, with your permission, I'd be happy to jump in and add a few extra commits. I appreciate that you may not have more time to spend on this. |
gentlegiantJGC
added a commit
to gentlegiantJGC/xmastree2020
that referenced
this pull request
Dec 24, 2021
Based upon the code from standupmaths#5 With a number of improvements including: 1) Thread support so the UI does not get blocked 2) Made the coordinates configurable as an input 3) Made the axis proportional in size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've already seen 2 pull request for "animation viewer" or "preview" features to make it easier to write animations.
Having looked at both in my opinion they're not very good, both are very slow to update and either require running in a web browser or significant modifications to the original code.
This pull request implements a better solution, it:
To use it you just need to change 2 lines of code: