Skip to content

Conversation

TomeHirata
Copy link
Collaborator

@TomeHirata TomeHirata commented Aug 13, 2025

Summary

  • warn via logger when deprecated requires_permission_to_run is supplied to MIPROv2.compile

@okhat
Copy link
Collaborator

okhat commented Aug 14, 2025

Awesome, but should this actually crash instead? If someone says "Require permission: True", it should just crash I think. (Please feel free to merge directly when ready.)

@TomeHirata
Copy link
Collaborator Author

Thanks, actually I think the following behavior is correct as the previous default is True

  • User selects requires_permission_to_run=False -> show warning
  • Users explicitly selects requires_permission_to_run=True -> raise exception

@TomeHirata TomeHirata merged commit c698547 into main Aug 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants