Skip to content

Conversation

gnetsanet
Copy link
Contributor

This PR adds concise Google-style docstrings for four public methods in
dspy/signatures/signature.py:

  • Signature.prepend
  • Signature.append
  • Signature.insert
  • Signature.delete

✅ Verified each method’s behavior in IPython using a local test script
✅ No logic or functional changes

Refs #8944

Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! do you want to close #8943 and keep this one open?

Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the PR!

This looks good! left some comments

@gnetsanet gnetsanet force-pushed the docs/signature-docstrings-batch2 branch from 4cb2c09 to 118904b Compare October 18, 2025 21:21
Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! this reads pretty good now. Last batch of comments, then we are good to go

@gnetsanet
Copy link
Contributor Author

Thank you for the feedback @chenmoneygithub.

Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenmoneygithub chenmoneygithub merged commit 097cd37 into stanfordnlp:main Oct 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants