-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[docs] Add Google-style docstrings for Signature.prepend/append/insert/delete #8945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add Google-style docstrings for Signature.prepend/append/insert/delete #8945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! do you want to close #8943 and keep this one open?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the PR!
This looks good! left some comments
…ring per style guide
…rt, and delete; completes Signature class docstrings (fixes issues stanfordnlp#8942 and stanfordnlp#8944)
4cb2c09
to
118904b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! this reads pretty good now. Last batch of comments, then we are good to go
Thank you for the feedback @chenmoneygithub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds concise Google-style docstrings for four public methods in
dspy/signatures/signature.py
:Signature.prepend
Signature.append
Signature.insert
Signature.delete
✅ Verified each method’s behavior in IPython using a local test script
✅ No logic or functional changes
Refs #8944