Fix #60: Merge duplicate factory implementations#61
Closed
Conversation
- Consolidate Factory class and _default_input_converter from factory_.py into factory.py - Update imports in factory_wrapper.py and factory_executor_manager.py - Remove duplicate factory_.py file - Add __all__ exports for clean public interface Addresses issue #60: eliminates code duplication while preserving all existing functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use TYPE_CHECKING imports in factory_wrapper.py and factory_executor_manager.py - Add local import in _not_same_session_factory method to resolve runtime NameError - All tests now pass successfully (22 passed, 2 skipped) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the duplicate factory implementations (
factory.pyandfactory_.py) into a single, well-organized module to eliminate code duplication and improve maintainability.Changes Made
Factoryclass fromfactory_.pyintofactory.py_default_input_converterfunction fromfactory_.pyintofactory.pyfactory_wrapper.pyandfactory_executor_manager.pyfactory_.pyfile__all__exports for clean public interfaceTest Results
All existing tests pass successfully:
Acceptance Criteria Verification
factory.pyexists after completion__all__Impact
🤖 Generated with Claude Code