apollo_infra: move metrics initialization to apollo_infra #10458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 27, 2025
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
from
1c5f794 to
cddd805
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
from
2772684 to
ee625e3
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
from
cddd805 to
cbf20c1
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
from
ee625e3 to
08a92ba
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
from
cbf20c1 to
fcd9077
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
from
08a92ba to
c40d091
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
from
fcd9077 to
8ca79f7
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
from
c40d091 to
cad9616
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
from
8ca79f7 to
5c1e689
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
from
cad9616 to
3f8af4e
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
from
5c1e689 to
0a1c942
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
from
3f8af4e to
dcb4b07
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
2 times, most recently
from
c2a24f6 to
d93203d
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
2 times, most recently
from
426b324 to
6abf59c
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
2 times, most recently
from
4e5f7a6 to
acb61ff
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
from
6abf59c to
9f94d56
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
2 times, most recently
from
bee66da to
dd4f3f4
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
2 times, most recently
from
7f1ca0d to
25ecda0
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
from
dd4f3f4 to
1eecb66
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
from
25ecda0 to
cac95d6
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
from
1eecb66 to
cac763c
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
from
cac95d6 to
4fcf803
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
from
cac763c to
1518581
Compare
Itay-Tsabary-Starkware
requested changes
Dec 3, 2025
Contributor
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/apollo_monitoring_endpoint/src/monitoring_endpoint.rs line 5 at r2 (raw file):
use apollo_infra::component_definitions::ComponentStarter; use apollo_infra::metrics::MetricsConfig; use apollo_infra::tokio_metrics::setup_tokio_metrics;
Please verify this fn doesn't have unnecessary pub visibilty
Code quote:
setup_tokio_metrics
nadin-Starkware
force-pushed
the
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
branch
from
4fcf803 to
e029d08
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
2 times, most recently
from
6fb60e1 to
bbafc11
Compare
nadin-Starkware
commented
Dec 3, 2025
Collaborator
Author
nadin-Starkware
left a comment
nadin-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/apollo_monitoring_endpoint/src/monitoring_endpoint.rs line 5 at r2 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Please verify this fn doesn't have unnecessary
pubvisibilty
Done.
graphite-app
bot
changed the base branch from
11-27-apollo_infra_extract_metricsconfig_from_monitoringendpointconfig
to
graphite-base/10458
nadin-Starkware
force-pushed
the
graphite-base/10458
branch
from
e029d08 to
104a7e7
Compare
nadin-Starkware
force-pushed
the
11-27-apollo_infra_move_metrics_initialization_to_apollo_infra
branch
from
bbafc11 to
a9780b3
Compare
graphite-app
bot
changed the base branch from
graphite-base/10458
to
main-v0.14.1
Merge activity
|
Itay-Tsabary-Starkware
approved these changes
Dec 4, 2025
Contributor
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
@Itay-Tsabary-Starkware reviewed 3 of 6 files at r1, 2 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.