apollo_class_manager_types: in convert_internal_rpc_tx_to_executable_tx move 2 awaits into join

[TzahiTaub]

No description provided.

[reviewable-StarkWare]

This change is 

[TzahiTaub]

• apollo_class_manager_types: in convert_internal_rpc_tx_to_executable_tx move 2 awaits into join #10461 👈 (View in Graphite)
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArniStarkware]

@ArniStarkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)

---

crates/apollo_class_manager_types/src/transaction_converter.rs line 236 at r1 (raw file):

                    self.get_sierra(tx.class_hash),
                    self.get_executable(tx.class_hash)
                )?;

This is not the first time you have made this change.
Do we need a self.get_contract_classes/ self.get_sierra_and_executable?

Code quote:

                let (sierra, contract_class) = tokio::try_join!(
                    self.get_sierra(tx.class_hash),
                    self.get_executable(tx.class_hash)
                )?;

[TzahiTaub]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

---

crates/apollo_class_manager_types/src/transaction_converter.rs line 236 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

This is not the first time you have made this change.
Do we need a self.get_contract_classes/ self.get_sierra_and_executable?

Nope, this was accidently opened twice and it isn't recognized by github apperanlty as it's the same change exactly

[TzahiTaub]

Merged in a different PR