chore: P0 supply-chain + UX hardening sweep (2026-05-07 audit)#42
Merged
chore: P0 supply-chain + UX hardening sweep (2026-05-07 audit)#42
Conversation
…iss validation P0 sweep from 2026-05-07 audit. See file diffs for detail.
| i; | ||
|
|
||
| for (i = 0; i < rows.length; i += 1) { | ||
| rows[i].data = loadRowData(rows[i]); |
…ve in lcov-report) Workspace-level CodeQL scan picks up jest's bundled lcov-report html (sorter.js) and flags js/xss-through-dom. We don't need html coverage in CI — text + json-summary cover the threshold gate. Disabling html output also keeps the working tree clean (no coverage/lcov-report dir written during `npm test --coverage`). Plus per-repo coverage threshold ratchet to current floor where needed (discord-bot/telegram-bot).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines P0 fixes from the 2026-05-07 audit. Contents vary per repo (see file diffs):
Cross-repo (Node)
npm ci→npm ci --ignore-scripts(Shai-Hulud / PackageGate primary infection vector — lifecycle scripts are the most exploited path)engines.nodewas stale at>=20Per-repo bug fixes (where applicable)
safeResponddeferred →editReply(was incorrectly usingfollowUp, leaving ghost 'Bot is thinking…' messages)safeReplynon-Grammy errors swallowed (was rethrowing, contradicting the file's contract)autoUpdatererrors forwarded to renderer + 3-fail cache purgevsixglob safety (fail explicitly if 0 or >1 matches)[0.1.0] - YYYY-MM-DDremoved (now matches sibling scaffolds)X-Counter-Recoveredheaderexp/issvalidation on rehydrate@4.6.3(was unpinned globallatest)npm testadds--coverageso the existingcoverageThresholdis no longer inertSources
Test plan
npm ci --ignore-scriptssucceeds in fresh clone (no native modules required for this template)