Open
Conversation
Contributor
Author
|
Ready for review |
Contributor
|
Contributor
|
Besides the tests not passing as Jeff mentioned, your api test at learningResource.spec.js is missing the deleteRecord function and you should remove the 'fullstack' in the datasources.json but instead move it to a local one. When running tests, there's lint errors which means the latest fix to the lint errors from master weren't merged yet. |
Contributor
|
Can we rename the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://screencast.com/t/DwWNjKjN9QP9