Minor fix in objects dimensions#26
Open
nataliakoliou wants to merge 2 commits intostasinos:masterfrom
Open
Conversation
Owner
|
Thank you for the fix @nataliakoliou |
Contributor
Author
|
Sorry for the oversight! Thank you @stasinos for pointing that out. I have removed the try-except block it in the updated code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've refined the make_square and make_long functions to address a potential issue where generated shapes could exceed the specified max_dim limit along the x or y axis.
In the make_square function, we've adjusted the calculation of the upper limit (lim) for the random delta to ensure that the generated square stays within the specified max_dim along either the x or y axis.
Similarly in the make_long function, we've adjusted the calculation of lim_x2 and lim_y2 to prevent the generated long shape from exceeding the specified max_dim along either the x or y axis.
Closes #23