feat: uncapping numpy and setuptools versions#17
Open
NatPRoach wants to merge 1 commit intostatbiophys:mainfrom
Open
feat: uncapping numpy and setuptools versions#17NatPRoach wants to merge 1 commit intostatbiophys:mainfrom
NatPRoach wants to merge 1 commit intostatbiophys:mainfrom
Conversation
Contributor
|
Hi, thanks a lot. We are updating numpy in version 2 indeed. I will release a minor with updated numpy and setuptools |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this would uncap the numpy version being used in HILARy. I took a look at where numpy is being used, and I think there are no aspects of the numpy API being used by HILARy that have changed between numpy 1.2 and numpy 2. It also uncaps the version of setuptools, which I think should be okay to be more flexible than specified, but can cause build issues elsewhere when capped.