Skip to content

Conversation

@bol-project
Copy link

No description provided.

shargon and others added 29 commits January 16, 2025 14:23
* Step 1

* Roman's feedback

* Move to settings

* Disable compression

* change to private
* Happy new year

* more
* Neo.Json.Benchmarks

* update

* Add more Benchmark classes

* Add Benchmark scores

* update

* format

* null control

* clean enter

* Update Benchmark_JsonDeserialize.cs

* 2025

---------

Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com>
* Fix state

* Update src/Plugins/StateService/StatePlugin.cs
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
* Nullable

* Optimize

* Fix nullables

* Fix ut

* More

* Update src/Neo/Persistence/DataCache.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* Update src/Neo/Persistence/MemorySnapshot.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* Update src/Neo/Persistence/MemoryStore.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* Remove pragma

* Clean

* SnapshotCache

* Change exception

* Fix conflicts

* Update src/Neo/Persistence/DataCache.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* Update src/Neo/Persistence/DataCache.cs

Co-authored-by: nan01ab <yjcc201374@outlook.com>

* Avoid logic change

---------

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Co-authored-by: nan01ab <yjcc201374@outlook.com>
* more 2025

* 2023->2025
… impls. (#3682)

* fix: same behavior if keyPrefix is null in IStore.Seek

* Update src/Plugins/LevelDBStore/IO/Data/LevelDB/Helper.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* Update src/Neo/Persistence/IReadOnlyStore.cs

---------

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Co-authored-by: Shargon <shargon@gmail.com>
* improve: remove unneccesarry lock  in Snapshot implementations

* improve: add comments

* improve: remove unneccesarry  in Snapshot implementations

* optimization: use Lock object

* Update benchmarks/Neo.Benchmarks/Persistence/Bechmarks_LevelDB.cs

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
* Updated Dotnet version and enforced it
Changed compiler to latest
Disabled warning in brenchmarks

* Update benchmarks/Directory.Build.props

* Update Directory.Build.props

---------

Co-authored-by: Shargon <shargon@gmail.com>
* Fixed warning and enforced warnings as errors

* Fixed warning and enforced warnings as errors

* revert some stuff

* Update Neo.Json.Benchmarks.csproj

* Update Directory.Build.props

* Update Directory.Build.props

* Update Directory.Build.props

* Update ConsoleServiceBase.cs

* Dotnet format

* Update Directory.Build.props

* Update Directory.Build.props

* Enforement

* Update UT_DataCache.cs

* Update UT_DataCache.cs

* Clean

* More clean

* var

* Remove !

---------

Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com>
* Nullable leveldb

* Add Seek

* Fix warnings

* Unify

* Update Helper.cs
* Nullable rocks db

* fix

* format

---------

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
…ryStore and LevelDbStore (#3689)

Co-authored-by: Shargon <shargon@gmail.com>
* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* add hardofork HF_Echidna

* Add entries to `Designation` event (#3397)

* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count

* [Neo Core StdLib] Add Base64url (#3453)

* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.

* format

* Fixed typo

* Added back #3397

* Fixed tests

* fixed global.json

* Update src/Neo/Neo.csproj

* Update src/Neo/Neo.csproj

* [`Fix`]: integer overflow in `JumpTable.SubStr ` (#3496)

* fix: int overflow in SubStr

* fix: int overflow in SubStr

* format

* Versioning change

* Clean

* Rename

* Show change

* Space

* remove duplicated lines in gitignroe

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Shargon <shargon@gmail.com>

* Fix NEO callstates (#3599)

* Allow callstates to use HF

* Rename to method

* Other rename

* Change the way

* Reduce changes

* Reduce changes

* Adapt name always

* Avoid string when only is lower the first char

* UT

* Test all

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* Reuse Load from stream

* Unify

* Fix default logic

* Change ContractMethod to allowMultiple

* Use LowerInvariant

* Move CheckingHardfork

* Remove optional arg

* Fix build

* Avoid file not found error

---------

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* fix tests error (#3636)

* fux build error

* Update src/Neo/SmartContract/ApplicationEngine.cs

---------

Co-authored-by: Shargon <shargon@gmail.com>

* NeoToken: accept candidate registration via onNEP17Payment (#3597)

Solves two problems:
 * inability to estimate GAS needed for registerCandidate in a regular way
   because of its very high fee (more than what normal RPC servers allow)
 * inability to have MaxBlockSystemFee lower than the registration price
   which is very high on its own (more than practically possible to execute)

Fixes #3552.

Signed-off-by: Roman Khimov <roman@nspcc.ru>

* specify the argument exception information.

* Fix Ut (#3635)

* NeoToken: add NEP-27 to supported standards list starting from Echidna (#3643)

#3597 introduces `onNEP17Payment`
handler to native NeoToke contract starting from Echidna hardfork. We
need to update the list of supported standards respectively.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* ut: fix HF_Echidna unit tests (#3646)

* Fix UT

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: nan01ab <yjcc201374@outlook.com>

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: nan01ab <yjcc201374@outlook.com>

* Update src/Neo/ProtocolSettings.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: nan01ab <yjcc201374@outlook.com>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* [Core Add] Add support to Ed25519 (#3507)

* fix unnecessary change

* Clean using

---------

Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com>

* Fix `HF_Echidna` comments (#3679)

* Fix obsolete

* Fix https://github.com/neo-project/neo/pull/3454/files#r1912152270

* Fix comment

* Update RoleManagement.cs

* Unset HF_Echidna

* Revert getTransaction

* Revert verifyWithECDsa

* format

---------

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Co-authored-by: nan01ab <yjcc201374@outlook.com>
Co-authored-by: Roman Khimov <roman@nspcc.ru>
Co-authored-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
* fix the bug

* Update RemoteNode.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

---------

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
* clean

* Fix ut
Test: add tests for implicit requirement of 'ApplicationEngine', 'DataCache' and 'IReadOnlyStoreView' parameter position in ContractMethod

Co-authored-by: Shargon <shargon@gmail.com>
* optimize: Murmur3 should be no cryptographic hash algorithm

* Avoid double initialize when only call once ComputeHash

* Rename

* Allow to append

* Update src/Neo/Cryptography/Murmur32.cs

* Update src/Neo/Cryptography/Murmur32.cs

Co-authored-by: Shargon <shargon@gmail.com>

---------

Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com>
Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
* Fix warnings

* Update src/Neo/Persistence/DataCache.cs
* remove FluentAssertions

* Update UT_OrderedDictionary.cs

* Removed dummy new code

* Update tests/Neo.UnitTests/Wallets/UT_Wallet.cs

* add missing files back and apply shargon suggestion

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Jimmy <jinghui@wayne.edu>
* [`Fix`] ByteArrayComparer

* Fix bug if 2GB arrays

* Fix description of `ByteArrayComparer`
* ['Bug'] MemoryStore and MemorySnapshot

* Added more tests

* Update tests/Neo.Plugins.Storage.Tests/StoreTest.cs

* Update src/Neo/Persistence/MemorySnapshot.cs

Co-authored-by: nan01ab <yjcc201374@outlook.com>

* Update tests/Neo.Plugins.Storage.Tests/StoreTest.cs

* Do same test in all storages

* Clean my UTs

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: nan01ab <yjcc201374@outlook.com>
* Exclude tests

* Update .github/workflows/main.yml

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

---------

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
* Feature: use IReadOnlyStoreView when readonly access on storage

* fix an issue

* Fix `NeedSnapshot`

* fix: unify style

* Feature: use IReadOnlyStoreView when readonly access on storage

* Feature: use IReadOnlyStoreView when readonly access on storage

* Feature: add unit tests for NeedSnapshot and NeedApplicationEngine

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
shargon and others added 30 commits November 26, 2025 09:34
* Treasury

* Update src/Neo/SmartContract/Native/Treasury.cs
Co-authored-by: Shargon <shargon@gmail.com>
* Whitelist in N4

* clean using

* format

* Update src/Neo/SmartContract/ExecutionContextState.cs

Co-authored-by: Erik Zhang <erik@neo.org>

* Clean in destroy and clean usigns

* Use StorageKey changes

* fix merge

* fix merge

* Use offset instead of method and argCount

* Update tests/Neo.UnitTests/SmartContract/Native/UT_PolicyContract.cs

Co-authored-by: Alvaro <amjarag@gmail.com>

---------

Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Alvaro <amjarag@gmail.com>
* Optional snapshot

* Apply suggestions from code review

Remove default

Co-authored-by: Erik Zhang <erik@neo.org>

* add unit tests

* Revert some changes

---------

Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Alvaro <amjarag@gmail.com>
* Native: remove Echidna mentions from native Policy

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Native: extend callflags of Policy's blockAccount

Port #4385.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

---------

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
* Check protected methods used by TokenManagement

* Use _ prefix

---------

Co-authored-by: Alvaro <amjarag@gmail.com>
Co-authored-by: Shargon <shargon@gmail.com>
* Implement BIP-0039

* Optimize

* Add MnemonicToEntropy()

* camelCase

---------

Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
Co-authored-by: Shargon <shargon@gmail.com>
* Happy new year 2026

* dotnet format
* Allow to remove tx from memPool

* Use event

* Fix ut

* NewTransactionEventArgs

---------

Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com>
Co-authored-by: Alvaro <amjarag@gmail.com>
Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Shargon <shargon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.