column serving issue and other fixes #7528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Sep 22, 2025
| current_id = node_id | ||
|
|
||
| while custody_groups.lenu64 < custody_group_count: | ||
| let safe_count = min(custody_group_count, cfg.NUMBER_OF_CUSTODY_GROUPS) |
There was a problem hiding this comment.
https://github.com/ethereum/consensus-specs/blob/v1.6.0-beta.0/specs/fulu/das-core.md#get_custody_groups defines it as an error to do this:
assert custody_group_count <= NUMBER_OF_CUSTODY_GROUPS
# Skip computation if all groups are custodied
if custody_group_count == NUMBER_OF_CUSTODY_GROUPS:
return [CustodyIndex(i) for i in range(NUMBER_OF_CUSTODY_GROUPS)]but that would make things more complicated to return anything like an Opt or Result, so there needs to be some default here. But sure, it's fine to effectively set this error handling as clamping.
There was a problem hiding this comment.
we can need the peer for blocks?
There was a problem hiding this comment.
we can need the peer for blocks?
That's compatible with not thinking it has any custody at all.
arnetheduck
reviewed
Sep 24, 2025
| let columns = dataColumnsOpt.valueOr: DataColumnSidecars @[] | ||
| debug "Inserting columns into database (backfill)", | ||
| indices = columns.mapIt($it[].index) | ||
| indices = columns.mapIt($it[].index).len |
There was a problem hiding this comment.
mapIt will cause the allocation of an extra seq and some extra processing - if we're just getting the length, this is wasteful
siddarthkay
pushed a commit
that referenced
this pull request
Sep 24, 2025
* column serving issue and other fixes * another change * remove downscore * fixes
siddarthkay
pushed a commit
that referenced
this pull request
Sep 24, 2025
* column serving issue and other fixes * another change * remove downscore * fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.