Skip to content

fix: validate price_id format to reject invalid characters #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Washio20 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate price_id format to reject invalid characters #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7320,6 +7320,7 @@
"price_id": {
"type": "string",
"nullable": true,
"pattern": "^[a-zA-Z0-9_-]+$",
"description": "Stripe price ID for billing purposes."
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating the description to document the validation pattern, similar to how device_id documents its format constraints. For example: "Stripe price ID for billing purposes. Must contain only alphanumeric characters, underscores, or hyphens." This would help API consumers understand the validation requirements without needing to inspect the schema.

Suggested change
"description": "Stripe price ID for billing purposes."
"description": "Stripe price ID for billing purposes.\nMust contain only alphanumeric characters, underscores (_), or hyphens (-).\n"

Copilot uses AI. Check for mistakes.
},
"status": {
Expand Down Expand Up @@ -7479,7 +7480,8 @@
},
"price_id": {
"type": "string",
"nullable": true
"nullable": true,
"pattern": "^[a-zA-Z0-9_-]+$"
},
"status": {
"$ref": "#/components/schemas/DeviceStatus"
Expand Down
2 changes: 2 additions & 0 deletions openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5786,6 +5786,7 @@ components:
price_id:
type: string
nullable: true
pattern: ^[a-zA-Z0-9_-]+$
description: Stripe price ID for billing purposes.
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating the description to document the validation pattern, similar to how device_id documents its format constraints. For example: "Stripe price ID for billing purposes. Must contain only alphanumeric characters, underscores, or hyphens." This would help API consumers understand the validation requirements without needing to inspect the schema.

Suggested change
description: Stripe price ID for billing purposes.
description: Stripe price ID for billing purposes. Must contain only alphanumeric characters, underscores (_), or hyphens (-).

Copilot uses AI. Check for mistakes.
status:
$ref: '#/components/schemas/DeviceStatus'
Expand Down Expand Up @@ -5970,6 +5971,7 @@ components:
price_id:
type: string
nullable: true
pattern: ^[a-zA-Z0-9_-]+$
status:
$ref: '#/components/schemas/DeviceStatus'
metadata:
Expand Down