Skip to content

fix: validate SN field rejects non-alphanumeric characters #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Washio20 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate SN field rejects non-alphanumeric characters #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1384,7 +1384,8 @@
"schema": {
"type": "string",
"minLength": 1,
"maxLength": 256
"maxLength": 256,
"pattern": "^[a-zA-Z0-9]+$"
},
"description": "Device serial number",
"example": "SFVA78RABZ12345678"
Expand Down Expand Up @@ -7308,7 +7309,10 @@
"sn": {
"type": "string",
"nullable": true,
"description": "Serial number of the device."
"description": "Serial number of the device.",
"pattern": "^[a-zA-Z0-9]+$",
"minLength": 1,
"maxLength": 256
},
"display_name": {
"type": "string",
Expand Down Expand Up @@ -7447,7 +7451,10 @@
},
"sn": {
"type": "string",
"description": "Serial number of the device. This field is required when creating a device."
"description": "Serial number of the device. This field is required when creating a device.",
"pattern": "^[a-zA-Z0-9]+$",
"minLength": 1,
"maxLength": 256
}
}
},
Expand All @@ -7469,7 +7476,10 @@
},
"sn": {
"type": "string",
"nullable": true
"nullable": true,
"pattern": "^[a-zA-Z0-9]+$",
"minLength": 1,
"maxLength": 256
},
"display_name": {
"type": "string",
Expand Down Expand Up @@ -7501,7 +7511,10 @@
"sn": {
"type": "string",
"description": "Device serial number",
"example": "SFVA78RABZ12345678"
"example": "SFVA78RABZ12345678",
"pattern": "^[a-zA-Z0-9]+$",
"minLength": 1,
"maxLength": 256
},
"model_name": {
"type": "string",
Expand Down Expand Up @@ -8255,4 +8268,4 @@
}
}
}
}
}
13 changes: 13 additions & 0 deletions openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,6 +1044,7 @@ paths:
type: string
minLength: 1
maxLength: 256
pattern: ^[a-zA-Z0-9]+$
description: Device serial number
example: SFVA78RABZ12345678
get:
Expand Down Expand Up @@ -5777,6 +5778,9 @@ components:
type: string
nullable: true
description: Serial number of the device.
minLength: 1
maxLength: 256
pattern: ^[a-zA-Z0-9]+$
display_name:
type: string
nullable: true
Expand Down Expand Up @@ -5942,6 +5946,9 @@ components:
type: string
description: Serial number of the device. This field is required when creating
a device.
minLength: 1
maxLength: 256
pattern: ^[a-zA-Z0-9]+$
DeviceUpdate:
allOf:
- $ref: '#/components/schemas/DeviceProperties'
Expand All @@ -5962,6 +5969,9 @@ components:
sn:
type: string
nullable: true
minLength: 1
maxLength: 256
pattern: ^[a-zA-Z0-9]+$
display_name:
type: string
nullable: true
Expand All @@ -5984,6 +5994,9 @@ components:
type: string
description: Device serial number
example: SFVA78RABZ12345678
minLength: 1
maxLength: 256
pattern: ^[a-zA-Z0-9]+$
model_name:
type: string
description: Device model name
Expand Down
Loading