Skip to content

Conversation

@Arekhimself
Copy link

No description provided.

@stdNullPtr stdNullPtr self-requested a review July 29, 2025 18:38
@stdNullPtr stdNullPtr added the enhancement New feature or request label Jul 29, 2025
@stdNullPtr
Copy link
Owner

@Arekhimself I am pleased to see a contribution request. However I must ask you what is the intention of these changes?

For example:

torchlight.permanent introduces a problem. The 'lit' areas will remain lit forever, even if you are NOT there anymore. This wouldn't be a good idea and would introduce memory issues given enough time. And it will light up the world in every place that a player passes through. Why would you want this?
If you have assumed your changes will make the torch lit infinitely - they will not, they will preserve all lit blocks infinitely. If you want longer light times use /torchlight time 30 for example

torchlight.off - what will this permission accomplish? You can already turn your torch off with /torchlight off

@Arekhimself
Copy link
Author

Arekhimself commented Jul 29, 2025

Hi.
command on and off are server wide but half of my players was very happy with torchlight on and the second half want it off.
the off perm is my first try to get the plugin player wide and have everybody happy. (even if a pro and a con mine together ;)

I was first think the permanent perm was a good idea but I see later in minecraft what you talk about.

I'm noob in plugin making plugin and I'm sorry for mistakes.

@stdNullPtr
Copy link
Owner

stdNullPtr commented Jul 30, 2025

Don't be sorry, I am very happy that you are using it and want to contribute.

It's fine that you do not have experience. I can extend the plugin for you. Let's do it the proper way:

Open an issue describing the issue you are facing, what behavior you would like to see, etc. With as much detail as possible.

I will implement it in the next few days.

Edit: Isn't the plugin off by default? If not, making it off by default should solve your issue right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants