Skip to content

Bugfix/create storage task#62 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bugfix/create storage task#62 #64

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b89bc43
adding volume check for idempotency
mhuber-avst Oct 3, 2025
5327e0e
fixed logic to ensure volumes aren't already in use
mhuber-avst Oct 3, 2025
12797b3
Updated linting
mhuber-avst Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions roles/server/tasks/install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,35 @@
name: test_volume
become: true

- name: Check if volumes are already configured

Check warning on line 13 in roles/server/tasks/install.yml

View workflow job for this annotation

GitHub Actions / ansible-lint / Ansible Lint

no-changed-when 

Commands should not change things if nothing needs doing.
ansible.builtin.shell:
cmd: |
for vol in {{ server_disk_volumes }} {{ server_disk_database }}; do
type=$(wipefs -O type -p $vol)
[[ ${{ '{' ~ '#' }}type} -eq 0 ]] && echo "${vol}: true" || echo "${vol}: false"
done
register: server_volume_usage
become: true

- name: Save volume config status to dict
ansible.builtin.set_fact:
server_vols: "{{ server_volume_usage.stdout | from_yaml }}"
become: true

- name: Prepare storage for volumes and database
ansible.builtin.command:
cmd: "mgr-storage-server {{ server_disk_volumes }} {{ server_disk_database }}"
when:
- server_disk_volumes is defined
- server_disk_database is defined
- server_disk_volumes is defined and server_vols[server_disk_volumes]
- server_disk_database is defined and server_vols[server_disk_database]
become: true

- name: Prepare storage for volumes
ansible.builtin.command:
cmd: "mgr-storage-server {{ server_disk_volumes }}"
when: server_disk_volumes is defined
when:
- server_disk_volumes is defined and server_vols[server_disk_volumes]
- server_disk_database is not defined
become: true

- name: Stage deploy configuration
Expand Down Expand Up @@ -68,3 +85,4 @@
creates: /root/.MANAGER_INITIALIZATION_COMPLETE
become: true
notify: Create initialization file

Loading