Skip to content

feat: add support for accessor arrays and refactor stats/base/stdevwd #6527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 5, 2025
Merged

feat: add support for accessor arrays and refactor stats/base/stdevwd #6527

merged 13 commits into from
Jul 5, 2025
+405 −120

Conversation

Ari1009
Copy link
Contributor

@Ari1009 Ari1009 commented Apr 3, 2025 •
edited
Loading

Resolves #5685

Description

What is the purpose of this pull request?

This pull request:

  • add refactor and add protocol support to stats/base/stdevwd

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Apr 3, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 3, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/stdevwd $\color{green}200/200$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}200/200$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title feat: add support for accessor arrays and refactor stats/base/stdevwd feat: add support for accessor arrays and refactor stats/base/stdevwd Apr 3, 2025
@kgryte kgryte requested a review from aayush0325 April 3, 2025 04:02
aayush0325
aayush0325 requested changes Apr 3, 2025
View reviewed changes
Copy link
Member

@aayush0325 aayush0325 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly address the CI failures and use #6248 as a reference PR, follow the conventions of benchmarks, examples docs, tests etc

aayush0325
aayush0325 reviewed Apr 3, 2025
View reviewed changes
aayush0325
aayush0325 reviewed Apr 3, 2025
View reviewed changes
@Ari1009 Ari1009 requested a review from aayush0325 April 5, 2025 14:29
@Ari1009
Copy link
Contributor Author

Ari1009 commented May 27, 2025

Any updates

@kgryte
Copy link
Member

kgryte commented May 27, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label May 27, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label May 27, 2025
@Ari1009
Copy link
Contributor Author

Ari1009 commented May 27, 2025

@aayush0325 can u give a recheck

@kgryte kgryte requested a review from gururaj1512 June 5, 2025 20:45
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jun 7, 2025
@gururaj1512
Copy link
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 18, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 18, 2025
@Ari1009
Copy link
Contributor Author

Ari1009 commented Jun 18, 2025

@aayush0325 can u give a recheck

gururaj1512 and others added 3 commits July 5, 2025 20:48
@gururaj1512
Merge branch 'develop' into accesor-stdevwd
653a95e 
Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>
@gururaj1512
fix: implementation
2b3a178 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@gururaj1512
chore: update benchmark script for improved clarity
4863442 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
gururaj1512
gururaj1512 previously approved these changes Jul 5, 2025
View reviewed changes
@gururaj1512 gururaj1512 requested a review from kgryte July 5, 2025 17:19
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 5, 2025
@kgryte kgryte removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Jul 5, 2025
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
@kgryte
docs: avoid redeclaration
28bb8ca 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
@kgryte
test: update require path
259bd5b 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Jul 5, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit c72df63 into stdlib-js:develop Jul 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@gururaj1512 gururaj1512 gururaj1512 left review comments

@aayush0325 aayush0325 Awaiting requested review from aayush0325

Assignees
No one assigned
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor and add protocol support to stats/base/stdevwd
5 participants
@Ari1009 @stdlib-bot @kgryte @gururaj1512 @aayush0325