feat: add number/float16/base/to-word
#8371
Open
+1,241
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/stdlib update-copyright-years |
stdlib-bot
added
the
bot: In Progress
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
stdlib-bot
removed
the
bot: In Progress
Member
|
/stdlib merge |
stdlib-bot
added
the
bot: In Progress
kgryte
reviewed
Nov 18, 2025
|
|
||
| #### toWord( x ) | ||
|
|
||
| Returns an unsigned 16-bit `integer` corresponding to the [IEEE 754][ieee754] binary representation of a [half-precision floating-point number][ieee754]. |
Member
There was a problem hiding this comment.
Suggested change
| Returns an unsigned 16-bit `integer` corresponding to the [IEEE 754][ieee754] binary representation of a [half-precision floating-point number][ieee754]. | |
| Returns an unsigned 16-bit integer corresponding to the [IEEE 754][ieee754] binary representation of a [half-precision floating-point number][ieee754]. |
stdlib-bot
removed
the
bot: In Progress
kgryte
reviewed
Nov 18, 2025
|
|
||
| b.tic(); | ||
| for ( i = 0; i < b.iterations; i++ ) { | ||
| x = ( randu()*1.0e7 ) - 5.0e6; |
Member
There was a problem hiding this comment.
@gururaj1512 Would you mind updating this file to use random/array/uniform and x[ i%x.length ], so that we can avoid PRNG generation within the hot loop?
kgryte
reviewed
Nov 18, 2025
| Parameters | ||
| ---------- | ||
| x: float | ||
| half-precision floating-point number. |
Member
There was a problem hiding this comment.
Suggested change
| half-precision floating-point number. | |
| Half-precision floating-point number. |
kgryte
reviewed
Nov 18, 2025
|
|
||
| Parameters | ||
| ---------- | ||
| x: float |
Member
There was a problem hiding this comment.
Suggested change
| x: float | |
| x: number |
kgryte
reviewed
Nov 18, 2025
| * limitations under the License. | ||
| */ | ||
|
|
||
| import toWordf = require( './index' ); |
Member
There was a problem hiding this comment.
s/toWordf/toWord/ here and below.
kgryte
reviewed
Nov 18, 2025
Member
There was a problem hiding this comment.
@gururaj1512 Did you test whether this generated the same results as the current "main" implementation?
Member
Author
There was a problem hiding this comment.
@kgryte Yaa, I have tested this implementation, and this is working as intended
kgryte
added
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves None.
Description
This pull request:
number/float16/base/to-wordRelated Issues
This pull request has the following related issues:
number/float64/base/to-float16#8207 to be mergedQuestions
No.
Other
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Got the first draft of code and basic understanding by consulting ChatGPT and claude.ai. But studied the implementation from various resources
@stdlib-js/reviewers