-
-
Notifications
You must be signed in to change notification settings - Fork 959
Add symbol/replace and has-replace-symbol-support packages #8534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@aryan7071 I suggest learning how to better prompt and leverage AI, as many of the changes to the existing package are undesired. As a first time contributor, I suggest spending time authoring contributions manually before using AI, as it is critical to familiarize yourself with project conventions in order to know expectations and standards. |
|
Thanks for the feedback. @kgryte sir |
|
Ref: a68d5d9 |
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
Resolves #8479
Description
This pull request implements the RFC to add support for two new packages:
1.
@stdlib/symbol/replaceSymbol.replacewhen supported by the environment.undefinedin environments without nativeSymbol.replacesupport.symbol/iteratorsymbol/async-iteratorsymbol/has-instance2.
@stdlib/assert/has-replace-symbol-supportSymbol.replace.has-replace-symbol-support)This PR follows the package-creation checklist outlined in the RFC:
Symbol.replaceRelated Issues
symbol/replace#8479Questions
No.
Other
No additional information.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored and implemented by me. I used ChatGPT to help with formatting, code and test scaffolding, documentation consistency, and to confirm that the package layout and conventions match other stdlib packages. All final code, edits, and decisions were reviewed and approved by me before submission.
@stdlib-js/reviewers