Conversation
Durables Support, Basic Semver, Tests
PEP-8 style compatibility
|
I am not the king of the hill. I'm happy to change code styles if they make sense. Maybe you can sell me on this idea that I personally hate. I like to use this style: Other people like this (which I hate): The thing I'm demonstrating is that the |
|
We do not include IDE specific files in our repos. In addition, before merging something like this we'd need to see if any of our other repos have adopted style-guides for python, and evaluate. @bobinson - I'd suggest creating an issue, outlining what it is you're trying to achieve with Pep 8 and how it makes tinman better than it is today. That'll give us something to review-from. I'm leaving this PR open, but it is not to be considered for merging until the |
|
@inertia186 & @relativityboy : I will revert with an issue report detailing why we need a generic coding style. Also removed the non-standard editor files which was there by mistake. Just to add to @inertia186's points, I am also not "religious" about a certain coding style over another one (for that matter, I am not even religious about Vim or Emacs). For example, in this very PR I had kept the following non PEP8 compliant section as I found it pretty neat ;-) |
|
We see the changes. Thanks. Doing some internal legwork to see if this is something we want to adopt. |

This PR brings in PEP-8 compatibility to the Tinman codebase.