Add .csproj patching for publish output (fixes #1)#2
Merged
Conversation
- `dotnet frontend init` now patches .csproj to include frontend.config.yaml as a Content item with CopyToPublishDirectory, ensuring it's in publish output - `dotnet frontend check` validates .csproj has the Content item (warning) - Change missing-config log from LogWarning to LogDebug (expected behavior) - Add CsprojHelper shared utility and CsprojHelperTests - Update SPEC.md sections 10.1/10.2 and README.md - Bump version to 1.1.0 Closes #1
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotnet frontend initnow auto-patches the.csprojto includefrontend.config.yamlas a<Content>item withCopyToPublishDirectory="PreserveNewest", fixing the missing config indotnet publishoutputdotnet frontend checkvalidates the.csprojhas this entry (warning, not error)LogWarningtoLogDebug(missing config is expected, defaults are used)Test plan
dotnet buildcleandotnet packproduces 1.1.0 packagesCloses #1