Add leaves instance method #341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Currently working towards getting all these methods using scopes instead of moving all records through ruby. Want to hold off on this for just a little bit |
Collaborator
|
@llenodo any ideas how to do this in sql and not ruby? |
Collaborator
|
Also, I think this is going to generate way too many sql calls. |
Author
|
Might be a way to do w/ SQL but would be far more complicated. IMO better to put this in now and refactor later but if you dont like the implementation feel free to reject this PR and create an open issue instead |
kbrock
reviewed
Apr 18, 2018
Collaborator
kbrock
left a comment
kbrock
left a comment
There was a problem hiding this comment.
agreed sql is too much - I'll try and figure out a better test for this
| assert_equal descendants, lvl0_node.descendants | ||
| assert_equal [lvl0_node] + descendants, lvl0_node.subtree | ||
| # Leaves assertions | ||
| leaves = lvl0_node.descendants.select do |node| |
Collaborator
There was a problem hiding this comment.
ideas how to test this without just rewriting the implementation here?
Collaborator
|
see also #246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an instance method
leaveswhich returns all leaf nodes from a given node.