[WIP] Add option on how to handle orphans when arranging nodes #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendon
suggested changes
Mar 29, 2023
Contributor
brendon
left a comment
brendon
left a comment
There was a problem hiding this comment.
Looks good. Would definitely need a test or two to ensure it's working as it's such a mind-job every time reading that code :D
lib/ancestry/class_methods.rb
Outdated
| # @returns Hash{Node => {Node => {}, Node => {}}} | ||
| # If a node's parent is not included, the node will be included as if it is a top level node | ||
| def arrange_nodes(nodes) | ||
| def arrange_nodes(nodes, add_orphans: true) |
Contributor
There was a problem hiding this comment.
It might make more sense to call is rootify_orphans or perhaps in the reverse discard_orphans?
Collaborator
Author
|
WIP: functionality complete. need tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #539
@brendon is this what you had in mind?
How do you usually get into this method?
read: I'm wondering where we want to pass
add_orphans: false