Proposing minors improvements and more test coverage #4
Conversation
* Intro improved * No more TODOs
models/user.js
Outdated
| userEntry.mail.map(function(mail) { | ||
| userModel.emails.push(mail); | ||
| }); | ||
| userModel.emails = [...new Set(userModel.emails)]; |
There was a problem hiding this comment.
le spread operator (aka ...) est supporte a partir de la version 5.x... Du coup la doc annonce version 4... (juste au cas ou une vielle image docker n'a pas ete mise a jour 😄 )
There was a problem hiding this comment.
La doc dit: "⚠ this library "try" to use ES2015 (or ES6) capabilities, don't use it with nodejs under 4.x?"
There was a problem hiding this comment.
Yep, la doc devrait dire under 5.x 😄
models/user.js
Outdated
| ldapUserArray.map(function (userEntry) { | ||
| if (userEntry.mail != undefined) { | ||
| if (userEntry.mail instanceof Array) { | ||
| userEntry.mail.map(function(mail) { |
There was a problem hiding this comment.
Note pour plus tard:
Je pense que c'est pas la bonne utilisation map, je que ca pourrait etre remplace par:
| userEntry.mail.map(function(mail) { | |
| userEntry.mail.forEach(function(mail) { |
ou mieux remplacer le tout par:
userModel.emails = [...new Set(userEntry.mail)];There was a problem hiding this comment.
Suis aussi pour le spread operator
There was a problem hiding this comment.
spread, mais sur userEntry.mail (et pas l'autre) en etant sur que userEntry existe...
Co-Authored-By: stefanonepa <stefano.nepa@outlook.com>
The cache wasn't taking into consideration the param "isResultUniq", meaning that getUser and getUsers would return the same data, regardless of the isResultUniq param that should either return an Array or a single result.
Better tests and bugs fix
Close #3 * Get rid of cache callbacks * Use the same context for all the tests
[FIX] WARNING! node-cache legacy callback support will drop in v6.x
…dap-js into fix-ldap-connection-close
[RFA] epfl-idevelop → epfl-si
…dap-js into fix-ldap-connection-close
* clean up the test.js * improve the package.json script
Fix ldap connection close
5 participants
Among other things, this PR:
unitsRepo.getUnitById