This repository was archived by the owner on Nov 6, 2022. It is now read-only.
Open
Conversation
Owner
|
I'll take a look at this first thing, sorry it took so long to respond, didn't really have the time for this project. |
Owner
|
I think a better way to do this would be to distinguish between mysql and sqlite connections instead of adding checks for system specific actions, and then having a connection manager decide which connection to use based on what was selected. There are also code style issues but I haven't setup any CI checks yet. I'll try to do some work on this soon, gotta finish this delete functionality first tho. |
Author
|
I just did this as a quick proof of concept for Hacktoberfest. I agree it could be better, but you wrote the app in a way that makes it easy to implement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SQLite Support
.dbfiles with SQLite.Implementation