Skip to content
This repository was archived by the owner on Nov 6, 2022. It is now read-only.

Add SQLite Support#6

Open
ColinMcNeil wants to merge 4 commits intostefpankov:masterfrom
ColinMcNeil:master
Open

Add SQLite Support#6
ColinMcNeil wants to merge 4 commits intostefpankov:masterfrom
ColinMcNeil:master

Conversation

@ColinMcNeil
Copy link
Copy Markdown

Add SQLite Support

  • Implement a few changes to open .db files with SQLite.

Implementation

  • New connection now has a dropdown for SQLite
  • If SQLite is selected, only the db file will prompted

screen shot 2018-10-02 at 2 20 33 pm

@stefpankov
Copy link
Copy Markdown
Owner

I'll take a look at this first thing, sorry it took so long to respond, didn't really have the time for this project.

@stefpankov
Copy link
Copy Markdown
Owner

I think a better way to do this would be to distinguish between mysql and sqlite connections instead of adding checks for system specific actions, and then having a connection manager decide which connection to use based on what was selected. There are also code style issues but I haven't setup any CI checks yet. I'll try to do some work on this soon, gotta finish this delete functionality first tho.

@ColinMcNeil
Copy link
Copy Markdown
Author

I just did this as a quick proof of concept for Hacktoberfest. I agree it could be better, but you wrote the app in a way that makes it easy to implement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants