feat: add delete command for deleting tweets#63
Open
chris-sev wants to merge 2 commits intosteipete:mainfrom
Open
feat: add delete command for deleting tweets#63chris-sev wants to merge 2 commits intosteipete:mainfrom
chris-sev wants to merge 2 commits intosteipete:mainfrom
Conversation
- Add DeleteTweet to fallback query IDs (VaenaVgh5q5ih7kvyVjgtg) - Add deleteTweet method to TwitterClient posting mixin - Create new delete.ts command file - Register delete command in CLI program Usage: bird delete <tweet-id-or-url...> Supports both tweet IDs and full URLs, can delete multiple tweets in one call.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c00d8ba050
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add fallback to TWITTER_GRAPHQL_POST_URL on persistent 404 - Use tweet-specific referer header (matches other mutations) - Verify delete_tweet exists in response before reporting success - Add --json flag for JSON output support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For adding deleting tweets. Not sure if we want this in the CLI. But with great power comes... hilarious tweets?
This PR adds a
bird deletecommand for deleting tweets.Changes
DeleteTweetto fallback query IDs (usingVaenaVgh5q5ih7kvyVjgtg)deleteTweetmethod toTwitterClientposting mixindelete.tscommand filedeletecommand in CLI programUsage
Implementation
The implementation follows the same patterns as other mutation commands (
unbookmark, etc.):DeleteTweetmutation--jsonoutput flagAll existing tests pass. 🎉