refactor: simplify query ID architecture to runtime-only cache #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ADDITIONAL_FALLBACK_QUERY_IDS in twitter-client-constants.ts for operations that need multiple fallback IDs - Add UserByScreenName to FALLBACK_QUERY_IDS (was missing) - Add getQueryIdList() helper in twitter-client-base.ts that combines runtime cache, fallback ID, and additional fallbacks - Update all mixin files to use getQueryIdList() instead of hardcoded arrays - Reduces duplication and makes query ID management easier Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove two-tier caching (static JSON + runtime) in favor of single-tier (runtime cache only). Fresh IDs are fetched on first use; 404 errors trigger automatic refresh and retry. Changes: - Remove static query-ids.json and update-query-ids.ts script - Define TARGET_QUERY_ID_OPERATIONS as explicit const array - Simplify all client mixins to use centralized getQueryId() - Update refresh function to accept readonly string[] - Remove graphql:update npm script Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
odysseus0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies query ID management from two-tier caching (static JSON + runtime cache) to single-tier (runtime cache only).
Before:
query-ids.jsonshipped with the package as fallbackgetQueryId()returned cached value or fell back to static JSONAfter:
getQueryId()returns cached value or empty stringChanges
src/lib/query-ids.jsonandscripts/update-query-ids.tsTARGET_QUERY_ID_OPERATIONSas explicit const array in constantsgetQueryId()graphql:updatenpm scriptrefresh()to acceptreadonly string[]Why
Test plan
pnpm buildpassesrm ~/.config/bird/query-ids-cache.json && bird search "hello" -n 1- fresh IDs fetched and cached successfully🤖 Generated with Claude Code