refactor: extract pagination helper to reduce code duplication#80
Open
odysseus0 wants to merge 1 commit intosteipete:mainfrom
Open
refactor: extract pagination helper to reduce code duplication#80odysseus0 wants to merge 1 commit intosteipete:mainfrom
odysseus0 wants to merge 1 commit intosteipete:mainfrom
Conversation
Add paginateItems() method to TwitterClientBase that encapsulates the common pagination loop logic shared across 5 paged methods. This consolidates deduplication, cursor handling, maxPages limits, and query ID refresh on 404 errors into a single reusable helper. Refactored methods: - getLikesPaged (twitter-client-timelines.ts) - getBookmarksPaged (twitter-client-timelines.ts) - getBookmarkFolderTimelinePaged (twitter-client-timelines.ts) - searchPaged (twitter-client-search.ts) - getListTimelinePaged (twitter-client-lists.ts) Net reduction of ~160 lines while improving maintainability. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paginateItems()method toTwitterClientBasethat encapsulates common pagination loop logicChanges
The helper consolidates:
seensetmaxPageslimit handlingnextCursortracking for resumable paginationRefactored methods:
getLikesPaged(twitter-client-timelines.ts)getBookmarksPaged(twitter-client-timelines.ts)getBookmarkFolderTimelinePaged(twitter-client-timelines.ts)searchPaged(twitter-client-search.ts)getListTimelinePaged(twitter-client-lists.ts)Test plan
🤖 Generated with Claude Code